[Cata] tag wotlk S5 honor weapons as never available #1886
Conversation
ZeChrales
changed the title
|
For pull requests I'd advise not including Categories or LocalizationDB since those files tend to have a lot of merge conflicts. Also for these items, you have the CREATED timestamp, but not when it was ADDED to the game. These appearances should be available in Retail. Just gotta figure out which build to use. |
It was never added, even in retail. You can only get them with arsenal (which is correctly done already). You think I need to add the ADDED version from this arsenal addition ? |
ZeChrales
force-pushed
the
clean_cata_savage_pvp
branch
from
f2a1612 to
577806c
Compare
I'm not entirely sure. It looks like the arsenal itself uses a SYMLINK to this header to fill its contents. Since it was added in 7.2.0 according to its timeline, it should be appropriate to add that timeline to the weapons after their CREATED timeline entry. If we don't, those items will be marked as NYI in retail as well since SYM links only refer to external sources, not infer and replace timeline values for those sources. |
|
Done, but I don't see any diff in retail tooltips ! |
| @@ -101,108 +101,108 @@ root(ROOTS.PVP, applyclassicphase(WRATH_PHASE_ONE, run(MarkOfWHOOOWHATNow, bubbl | |||
| }), | |||
| -- Savage Gladiator weapons have never been implemented | |||
| i(42557, { -- Savage Gladiator's Barrier | |||
| ["timeline"] = { CREATED_3_0_2 }, | |||
| ["timeline"] = { CREATED_3_0_2, ADDED_7_2_0 }, | |||
There was a problem hiding this comment.
@ImUnicke Could you please help clarify, when "created" and "added" exist at the same time, will NYI be applied when the created timeline is true and the added timeline is false, and will NYI not be applied when the created timeline is true and the added timeline is true?
There was a problem hiding this comment.
I tested it in a retail environment, the version was 11.0.7, which met the created and added conditions, but it was still marked as NYI.
There was a problem hiding this comment.
I tested it in a retail environment, the version was 11.0.7, which met the created and added conditions, but it was still marked as NYI.
It wasn't reparsed for retail with pull preview. After it will look fine -
There was a problem hiding this comment.
It wasn't reparsed for retail with pull preview. After it will look fine -
okay, maybe it's an environment problem on my side, I didn't change anything after parser :( .
tested on cata classic
on retail, items are not flagged correctly because they were added in 7.x into the weapon arsenal, I suppose some specific flag should be added