refactor: make project more Zig-idiomatic #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @tensorush! thanks for doing all this cleanup! Appreciate the help 🥇 Taking a look at this now, but so far it LGTM |
|
im happy with these. Thanks! |
|
Awesome! You might have to switch GitHub Pages deployment from "Deploying from a branch" (by default) to "GitHub Actions". |
|
yup, just made that change and updated it. It looks like the docs deployed but the landing page is for Datetime only ? Is that expected or should the entire lib be showing in the root ? The entire lib is there, just have to search for it
…On Sun Jul 14, 2024, 02:00 PM GMT, Jora Troosh ***@***.***> wrote:
Awesome! You might have to switch GitHub Pages deployment from "Deploying from a branch" (by default) to "GitHub Actions".
Screenshot.png (view on web) <https://github.com/user-attachments/assets/6da8d046-5539-4e00-91f8-f02b7c24a8fb>
—
Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADBZ7BZJKAVRCOZ325376HLZMKABJAVCNFSM6AAAAABK2GCTROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGM2TSOBVG4>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Yeah, must be a bug. Everything that is |
|
no worries, i can bump to master, and see how things look |
|
hmm yeah looks like that doesnt fix it. Oh well, no big deal for now, just whenever you have your next PR see if you can find a solution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ATTron, great work on this library! It's cool to see more astro-/space-related Zig projects, especially since it's kind of been a Zig theme for some time, with the first Zig mascot, Zero, jet-packing around in a spacesuit.
I decided to contribute some changes to make your project have a more cleaned-up, Zig-idiomatic style.
See the official Zig Style Guide to explain some of the code changes. As for the removal of
const Self = @This();in most places, see this post from Loris.Also, I have a project that generates a new Zig executable or library project with the common repo niceties included, some of which I've added in this PR. For instance, now you can run all the build steps at once with
zig build. I wanted to add a step to run all the examples from the README as well, but I guess this PR is large enough, so I can do it for you in the next one.Feel free to point out anything that you think should be done differently. Cheers!