Feat new bigchat video embedding #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grayashh
previously approved these changes
Jun 17, 2024
Comment on lines
10
to
11
| default: | ||
| return <BigChatBackgroundTwentyThree width="100%" height="100%" />; |
There was a problem hiding this comment.
year가 non-null이라면 위쪽에서 year 를 판단해서 early return 해도 될 것 같습니다!
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@grayashh ㅋㅋㅋㅋㅋ오토 머지 설정을 까먹어서,,,여기다 커밋했다... 꼼수를 써보려고 했지만 멤버가 아니라 어림도 없었다.. |
grayashh
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
빅챗 비디오들이 유튜브에 올라와서, 관련 데이터와 임베딩 캐러셀을 추가합니다.
기존 빅챗은 2021년도 데이터뿐이어서 연도 구분이 없었는데, 2023 빅챗 영상이 추가 되면서 간단하게 연도 속성을 추가해뒀습니다.
그 외 자잘하게 height 밀리는 이슈들만 조금 수정했습니다.