Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address JOSS comments + prepare for v1.0 release #123

Merged
merged 47 commits into from
Jul 23, 2024
Merged

Address JOSS comments + prepare for v1.0 release #123

merged 47 commits into from
Jul 23, 2024

Commits on Jun 20, 2024

  1. refactor: Add preprocess and noise options to load_test_dataset

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9d068af View commit details
    Browse the repository at this point in the history

  2. refactor: Move preprocess_impedance_data to utils

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c403e29 View commit details
    Browse the repository at this point in the history

  3. refactor: Make matplotlib args in plot_nyquist and `plot_bode funct… 

    …ions` kwarg-only
    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    efa43a4 View commit details
    Browse the repository at this point in the history

  4. refactor: Add is_iterable and is_nested_iterable helpers to utils

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    401cd74 View commit details
    Browse the repository at this point in the history

  5. refactor: Add InferenceResult and ImpedanceData container classes

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b78b8a0 View commit details
    Browse the repository at this point in the history

  6. refactor: Add whole bunch of objects validators: circuit, p0, priors,… 

    … seed, and impedance
    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    09f3dd2 View commit details
    Browse the repository at this point in the history

  7. refactor: Major refactor of perform_bayesian_inference, now can do … 

    …SCSD, MCSD, and SCMD
    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    beba800 View commit details
    Browse the repository at this point in the history

  8. test: Add unit tests for SCSD, MCSD, SCMD inferences

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2a763a6 View commit details
    Browse the repository at this point in the history

  9. refactor: Replace partial module imports with absolute ones

    @ma-sadeghi
    ma-sadeghi committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    b129f3e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. refactor: Add flush_streams helper to utils.py

    @ma-sadeghi
    ma-sadeghi committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c7e66e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. chore: Fix typo in log warning message

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a23595b View commit details
    Browse the repository at this point in the history

  2. refactor: Add utils.flush_streams so progress bars render properly

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ce896e2 View commit details
    Browse the repository at this point in the history

  3. chore: Improve post-filtering warning message for empty circuits

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    95c39bd View commit details
    Browse the repository at this point in the history

  4. feat: Add is_ndarray_like helper function to utils.py

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9e1c1ec View commit details
    Browse the repository at this point in the history

  5. chore: Update type hints in utils.py to use Iterable instead of list

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a5a02d6 View commit details
    Browse the repository at this point in the history

  6. refactor: Remove unused circuit from parse_initial_guess args

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    41bf562 View commit details
    Browse the repository at this point in the history

  7. feat: Add get_parameter_bounds helper to utils.py

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d10179b View commit details
    Browse the repository at this point in the history

  8. feat: Add generate_initial_guess helper to utils.py

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    418d23b View commit details
    Browse the repository at this point in the history

  9. refactor: Propagate recent refactors

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    54accb9 View commit details
    Browse the repository at this point in the history

  10. refactor: Update fit_circuit_parameters based on recent API changes

    @ma-sadeghi
    ma-sadeghi committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5f4015a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. refactor: Standardize plotting functions to return ax object(s)

    @ma-sadeghi
    ma-sadeghi committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e204300 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. docs: Better error message

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    47907b3 View commit details
    Browse the repository at this point in the history

  2. refactor: Deep copy circuits dataframe to avoid modifying original

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    757b62f View commit details
    Browse the repository at this point in the history

  3. bug: p0 must be replicated for distribute_task to work

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    551d887 View commit details
    Browse the repository at this point in the history

  4. bug: Handle edge case where p0 was not found

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f9931e3 View commit details
    Browse the repository at this point in the history

  5. refactor: Ensure seed is a list for MCMD compatibility

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b61037b View commit details
    Browse the repository at this point in the history

  6. refactor: Propagate recent API changes throughout the codebase

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    94d9525 View commit details
    Browse the repository at this point in the history

  7. docs: Update docs to include new example notebooks + update basic usage

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c46b393 View commit details
    Browse the repository at this point in the history

  8. docs: Add new example notebooks

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    292ee80 View commit details
    Browse the repository at this point in the history

  9. refactor: Update perform_full_analysis per recent API changes

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    20ae908 View commit details
    Browse the repository at this point in the history

  10. docs: Remove moved function from docstrings

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    60de4f6 View commit details
    Browse the repository at this point in the history

  11. feat: Add new toy dataset (battery cycling)

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0af90a1 View commit details
    Browse the repository at this point in the history

  12. bug: Fixed edge case where handling R1 messed up with R10, etc.

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    612d8f0 View commit details
    Browse the repository at this point in the history

  13. refactor: validate_parameter now optionally raises Exception

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8f4b71e View commit details
    Browse the repository at this point in the history

  14. refactor: Implement repr for InferenceResult

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    99bd911 View commit details
    Browse the repository at this point in the history

  15. refactor: variables is now inferred from dict keys rather than pass… 

    …ed explicitly
    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    16bb5cd View commit details
    Browse the repository at this point in the history

  16. refactor: Use 'converged' instead of 'success' for consistency

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    ee94198 View commit details
    Browse the repository at this point in the history

  17. test: Update unit test per recent API changes

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    88f3491 View commit details
    Browse the repository at this point in the history

  18. feat: Forgot to add battery dataset assets

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    7853839 View commit details
    Browse the repository at this point in the history

  19. Use impedance.py fork until made compatible with NumPy 2.0

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b1965b1 View commit details
    Browse the repository at this point in the history

  20. refactor: Fix typo

    @ma-sadeghi
    ma-sadeghi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2766ab2 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. refactor: Don't clutter circuits dataframe with unnecessary columns

    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    583e302 View commit details
    Browse the repository at this point in the history

  2. refactor: Don't sort circuits dataframe, breaks indexing later

    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3bc75dc View commit details
    Browse the repository at this point in the history

  3. bug: Fix edge case where priors is still None when private SCSD funct… 

    …ion is called
    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    30b5830 View commit details
    Browse the repository at this point in the history

  4. refactor: print_inference_results should rank circuits internally (… 

    …without modifying circuits dataframe)
    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c4451f6 View commit details
    Browse the repository at this point in the history

  5. docs: Update basic workflow example notebook based on recent API changes

    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0c67ccb View commit details
    Browse the repository at this point in the history

  6. docs: Use more sensible default args in the example notebook to not t… 

    …imeout CI
    @ma-sadeghi
    ma-sadeghi committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    abd2e1e View commit details
    Browse the repository at this point in the history