-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inpainting implementation #35
Comments
The alternative implementation seems to be different and give better results; I have implemented it in PR #36 for your consideration. |
i tested both, its hard to tell, you might get lucky with resut and think wow it works better, i dont think any of those are using the proper inpainting model from here #20 Not sure how that model would change the results but its working good without it so far , k_euler_a gets best alignment with original image, other ones not so much |
I think that you are be right, it might have been pure luck. I have also gotten great results with Maybe we should run a side by side test with the same settings to confirm that no qualitative difference exists? |
this one has also inpainting but its without proimpt which is incomplete i think , tried to remove eyes and it wont do it, i think SD inpainting wont work without prompt You mean same seed for inpainting , theres no way you can draw the same looking mask in both uis , i had great results with this repo inpainting but the masking blurring code is reversed, its applied to inpainted image insteead of original image to blur the edges and gives very harsh edges https://i.postimg.cc/3rfxrP2J/inp.jpg |
Even though perfectly drawing the same mask two times would be impossible, a rough comparison would still be valuable imo. I agree that the edges are looking rough on the implementation here. |
I have managed to make a comparison by running the hlky repo on colab (https://github.com/daswer123/stable-diffusion-colab). It's not ideal since the masks are not exacly the same, but I think that it illustrates the differences. The anon-hlhl implementation that was merged on the hlky webui seems to blend better the masked part the image with its surroundings, while the current implementation here often gives this "image inside an image" effect where the masked part loses connection with the surrounding context.
|
support for --medvram attempt to support share
changes for inpainting for #35
Thank you so much @AUTOMATIC1111! Your rigorous test settles it: it was probably all just cherry picking and superstition on my end. It seemed reasonable to assume that doing the masking procedure for each iteration of the denoising process would give better results, but that doesn't seem to be the case. The new |
Hello,
Is the current inpainting implementation equivalent to this?
Sygil-Dev/sygil-webui#308
Thank you
The text was updated successfully, but these errors were encountered: