ModuleNotFoundError: No module named 'basicsr.losses.losses'

[ReinerBforartists]

Describe the bug
After updating the repo and running the webui,bat i got an error while setting up gfpgan.

ModuleNotFoundError: No module named 'basicsr.losses.losses'

Running it again though then worked. I nevertheless thought it is worth a report. Maybe you want to have a look at the code there.

[GalaxyTimeMachine]

Exactly the same for me after latest pull.

[PhreakHeaven]

The instructions now state to run 'webui-user.bat' instead. Not sure if that made a difference, but it did actually download/update GFPGAN and basicsr when I closed the terminal and ran that instead, with no errors this time.

[hyphenized]

Changed basicsr to basicsr==1.4.2 in requirements_versions.txt and it seems to be working fine. This might break other stuff though.

[an0maly33]

Tried 1.3.5 and 1.4.2. Getting this error with both as of my latest pull.

Launching with webui-user.bat

[djdookie]

When starting webui-user.bat I get the same error message with the latest master branch pull:

ModuleNotFoundError: No module named 'basicsr.losses.gan_loss'

[stormsson]

I confirm i have the same situation , even after multiple restarts

ModuleNotFoundError: No module named 'basicsr.losses.gan_loss'

[djdookie]

We recently got a downgrade commit for basicsr to v1.3.5 here.
6e68cc8

But it shouldn't be solved with this, because gfpgan and realesrgan seem to need basicsr >= v1.4.2.

pip install basicsr==1.3.5

Installing collected packages: basicsr Attempting uninstall: basicsr Found existing installation: basicsr 1.4.2 Uninstalling basicsr-1.4.2: Successfully uninstalled basicsr-1.4.2 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. gfpgan 1.3.5 requires basicsr>=1.4.2, but you have basicsr 1.3.5 which is incompatible. realesrgan 0.2.5.0 requires basicsr>=1.4.2, but you have basicsr 1.3.5 which is incompatible. Successfully installed basicsr-1.3.5

Please fix this bug, because GFPGAN is not working in this repo right now. At least for some people.
I wonder why it's working fine in other rops like https://github.com/sd-webui/stable-diffusion-webui

[djdookie]

Ok I did a deep dive.

This broke it: TencentARC/GFPGAN@7d657f2
coming from this PR TencentARC/GFPGAN#210
A revert like this helps using GFPGAN again: AdamBear/GFPGAN@8ef599d

TL;DR: Hotfix this by opening .\venv\Lib\site-packages\gfpgan\models\gfpgan_model.py
and replace from basicsr.losses.gan_loss import r1_penalty
with from basicsr.losses.losses import r1_penalty

[djdookie]

Under Windows if you use the web-user.bat to start you can remove or rename the venv folder, set these versions in the requirements_versions.txt:

basicsr==1.4.2
gfpgan==1.3.8

Then call web-user.bat. This will create the local venv with compatible versions without the mentioned bug if you didn't define any VENV_DIR in the web-user.bat.
Directly calling python launch.py should work too.

Not setting the explcit gfpgan version also worked for me after removing the venv directory.