Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sampler not working in X/Y Plot #4860

Closed
1 task done
2x-y opened this issue Nov 19, 2022 · 16 comments
Closed
1 task done

[Bug]: Sampler not working in X/Y Plot #4860

2x-y opened this issue Nov 19, 2022 · 16 comments
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@2x-y
Copy link

2x-y commented Nov 19, 2022

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

Using the sampler names in the X/Y Plot no longer changes the sampler

Steps to reproduce the problem

In txt2img, select the "X/Y Plot" script
Set "X Type" to "Sampler"
Enter "Euler a,Euler,LMS,Heun,DPM2"
Generate the plot

What should have happened?

Images should be generated by each of the samplers in the plot but the selected sampler is used instead.

Commit where the problem happens

Commit hash: ccd73fc

What platforms do you use to access UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

--xformers --opt-channelslast

Additional information, context and logs

No response

@2x-y 2x-y added the bug-report Report of a bug, yet to be confirmed label Nov 19, 2022
@Shangooriginal
Copy link

Yep, experiencing the same problem

@djdookie
Copy link

Same here.
It worked fine 2 days ago.

@frosta95
Copy link

Same here too

@Gerschel
Copy link
Contributor

I thought it was working correctly, as the sampler names changed in the plot. But the resulting image does remain the same, the same sampler is used.

@MartinCairnsSQL
Copy link
Contributor

This line needs to be updated as the script was using the sampler index but now the WebUI uses the sampler name.

p.sampler_index = sampler_index

Change p.sampler_index to p.sampler_name and sampler_index to x

    p.sampler_name = x

@DoughyInTheMiddle
Copy link

Same. Was using it all night long, but everything was getting laggy, so I restarted the entire service and browser window to clean out RAM. Kept trying to fix it.

Hero Level:

This line needs to be updated as the script was using the sampler index but now the WebUI uses the sampler name.

p.sampler_index = sampler_index

Change p.sampler_index to p.sampler_name and sampler_index to x

    p.sampler_name = x

@Gerschel
Copy link
Contributor

Gerschel commented Nov 20, 2022

Complete fix.

p.sampler_name = sd_samplers.all_samplers[sampler_index].name

@Gerschel
Copy link
Contributor

Can someone else push it. I had a long week and I keep making stupid mistakes.

@nozoku
Copy link

nozoku commented Nov 23, 2022

Still getting the same problem - X/Y plot generates the same images despite setting different Samplers as one of the dimensions of the plot. I tried to edit xy_grid.py by myself - just made things worse ;)... using a new install of webui from today...

@randaller
Copy link

Still same problem, X/Y generates the same image like the first sampler.

@SoftwareLogico
Copy link

SoftwareLogico commented Nov 23, 2022

Not working here either

image

it generates the same image

@Humanoidme
Copy link

same here....

@satisl
Copy link

satisl commented Nov 24, 2022

same....

@SuperMarioSF
Copy link

currently I'm on commit f7dea1341413c42a3b24a1a3711a7f4eba7a3978 , and the problem still exists for now.

@Gerschel
Copy link
Contributor

I updated the code in my pull request. I did some commenting and refactoring to (hopefully) make it more clear. This time I had some rest and double, triple checked my code.

@MIC132
Copy link

MIC132 commented Nov 26, 2022

Same problem. So if I understand correctly fix is in a PR and we are waiting for it to get added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet