Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of unused/vestigial code #11046

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

akx
Copy link
Collaborator

@akx akx commented Jun 5, 2023

As found by Vulture and some eyes.

These things don't seem to be referenced anymore.

Checklist:

As found by Vulture and some eyes
@akx akx marked this pull request as ready for review June 5, 2023 20:13
@akx akx requested a review from AUTOMATIC1111 as a code owner June 5, 2023 20:13
@AUTOMATIC1111
Copy link
Owner

It would be preferable if some person with a lot extensions tested this before it's merged.

@w-e-w
Copy link
Collaborator

w-e-w commented Jun 7, 2023

instead of outright removing stuff we should use @deprecated
https://pypi.org/project/Deprecated/
you never know what extensions would do

@akx
Copy link
Collaborator Author

akx commented Jun 7, 2023

@w-e-w Maybe, but I'd also rather not add an extra dependency. (I cleaned deprecated out of Redis earlier: redis/redis-py#2386)

@w-e-w
Copy link
Collaborator

w-e-w commented Jun 7, 2023

sure
I just use the package because it is well known, no need to explain any concept

@AUTOMATIC1111 AUTOMATIC1111 merged commit 1bf01b7 into AUTOMATIC1111:dev Jun 27, 2023
@akx akx deleted the ded-code branch June 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants