-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update shared.opts.data when add_option #12957
Conversation
Signed-off-by: AnyISalIn <anyisalin@gmail.com>
This is now causing the default option(s) of extensions to be set on startup regardless of what the user has configured for themself. |
I notice this is just now too extensions using this method is fine stable-diffusion-webui/extensions-builtin/canvas-zoom-and-pan/scripts/hotkey_config.py Lines 4 to 15 in 5ef669d
|
Description
If we add a new option but don't save it in config.json, we won't be able to set it in
This will result in a KeyError being raised for
opts.data[k]
for example, we will override
control_net_no_detectmap
parameters, if we have no save it in config.json, we cannot to set it in API.Screenshots/videos:
Checklist: