Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable console prompts in settings #13119

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Sep 7, 2023

Description

add a UI settings under system for --enable-console-prompts
no reason why this should be restricted to a cmd arg

Screenshots/videos:

image

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner September 7, 2023 01:03
@AUTOMATIC1111
Copy link
Owner

should probably then remove the commandline option (or make it do nothing) because if the commandline option is on, the setting stops working.

use --enable-console-prompts as the default value for shared.opts.enable_console_prompts
@w-e-w
Copy link
Collaborator Author

w-e-w commented Sep 9, 2023

I made it so that --enable-console-prompts is the default value of shared.opts.enable_console_prompts
this way old users that are using --enable-console-prompts will have this setting set to True
for normal users the default will be false

after they have applied / saved the setting, the value in settings will take precedence and --enable-console-prompts ignored

I think it's a good way of transiting between the settings
but this also has the downside of my causing some confusion for users that are using --enable-console-prompts now and then decide to not use it later on

@AUTOMATIC1111 AUTOMATIC1111 merged commit 558808c into dev Sep 9, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the enable_console_prompts-in-settings branch September 9, 2023 07:02
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants