Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show the preview image in the modalview if available #13459

Merged
merged 1 commit into from
Oct 14, 2023
Merged

show the preview image in the modalview if available #13459

merged 1 commit into from
Oct 14, 2023

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Oct 1, 2023 •
edited
Loading

Description

  • show the current preview image if available in the lightboxModal view
  • without this fix, the modal View tries to show the last selected gallery image while in generating image state.

Checklist:

@wkpark wkpark requested a review from AUTOMATIC1111 as a code owner October 1, 2023 11:23
@AUTOMATIC1111
Copy link
Owner

Well, it is intended to show the image from the gallery...

@wkpark
Copy link
Contributor Author

wkpark commented Oct 2, 2023

Well, it is intended to show the image from the gallery...

while images are generating, thumbnails will be hidden, the default gallery disappears, and a preview image appears, but modal zoom view always tries to show the last selected gallery image, strange behavior.

@wkpark wkpark mentioned this pull request Oct 3, 2023
Open
1 task
@AUTOMATIC1111 AUTOMATIC1111 merged commit 771dac9 into AUTOMATIC1111:dev Oct 14, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
Closed
@w-e-w
Copy link
Collaborator

w-e-w commented Dec 6, 2023 •
edited
Loading

#14213 someone is asking for an option to disable this behavior

made a PR #14230

w-e-w added a commit that referenced this pull request Dec 6, 2023
@w-e-w
add option: Live preview in full page image viewer
9d2cbf8 
make #13459 "show the preview image in the modal view if available" optional
@w-e-w w-e-w mentioned this pull request Dec 6, 2023
Merged
4 tasks
This was referenced Dec 14, 2023
Merged
Closed
@w-e-w w-e-w mentioned this pull request Jun 25, 2024
Merged
4 tasks
ruchej pushed a commit to ruchej/stable-diffusion-webui that referenced this pull request Sep 30, 2024
@w-e-w @ruchej
add option: Live preview in full page image viewer
99a55ca 
make AUTOMATIC1111#13459 "show the preview image in the modal view if available" optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkpark @AUTOMATIC1111 @w-e-w