Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that retains effects of a previous model when switching models during LoRA use. #13917

Closed
wants to merge 2 commits into from

Conversation

hako-mikan
Copy link
Contributor

@hako-mikan hako-mikan commented Nov 9, 2023

Description

This fix addresses the issue where switching models during the use of LoRA would cause the influence of the original model to affect the subsequent one. This problem has been reported as several issues, but it remains unresolved due to problems such as non-reproducibility. As discussed in the issues, the impact given during the model switch is very minor, and if the part has the same weight in both the pre- and post-switch models, the generated image does not change and cannot be reproduced.

issues
#13516
#12619
#12872
There may also be reports of this as a separate issue.

Checklist:

@hako-mikan
Copy link
Contributor Author

I thought I had set it to the dev, but I made a mistake. My apologies.

@catboxanon
Copy link
Collaborator

This was also caught prior in #13178, which results in the diff being empty here since it's the same fix. Gonna go ahead and close this, but feel free to re-open if there's anything more to do.

@catboxanon catboxanon closed this Nov 9, 2023
@miguel234457
Copy link

still having this issue as of now, someone can look into this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants