Fix auto focal point crop for opencv >= 4.8 #14121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
Closed
w-e-w
force-pushed
the
fix-Auto-focal-point-crop-for-opencv-4.8.x
branch
from
d94f5d3
to
021cded
Compare
w-e-w
changed the title
1 task
w-e-w
force-pushed
the
fix-Auto-focal-point-crop-for-opencv-4.8.x
branch
from
021cded
to
d4e254d
Compare
Closed
1 task
w-e-w
force-pushed
the
fix-Auto-focal-point-crop-for-opencv-4.8.x
branch
from
4c6750f
to
3e735ef
Compare
autocrop.download_and_cache_models in opencv >= 4.8 the face detection model was updated download the base on opencv version returns the model path or raise exception
w-e-w
force-pushed
the
fix-Auto-focal-point-crop-for-opencv-4.8.x
branch
from
3e735ef
to
d608926
Compare
AUTOMATIC1111
approved these changes
Dec 2, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14118 [Bug]: auto focal point crop only work under opencv-python<4.8
#11727 [Bug]: Preprocess images in the "Train" tab crashes when "Auto Focal Point Crop" is selected
face detection model was updated in opencv 4.8+
face_detection_yunet_2022mar->face_detection_yunet_2023maropencv/opencv_zoo@f12e127
this PR
if opencv >= 4.8 downlaod the 2023 ver else 2022 ver
the 2023 version will use the filename
face_detection_yunet_2023mar.onnxwhere the 2022 version use the same filename as before
face_detection_yunet.onnxto avoid redownloadfor unknow reason
autocrop.pyused a mix of indent 2 and 4, I performed a re-format of the file