paste infotext cast int as float #14523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when casting the infotext string to it's corresponding element type the element type is determined by the default value saved in
ui-config.json
this causes issues in one particular case
if a slider is implemented with a value range of
[0, 1]
step size of0.1
default value1
if the developer set sleep value to
1
and not1.0
, a integer one will be saved toui-config.json
,later when trying to perform paste infotext, becaue the value is a integer the value will be cast to a integer, but in this particular case it should be a float
this will result in an incorrectly value beeing applied to the UI
this is a real issue that I have run into just now
when verifying an extension and decide to take a little bit of time to implement infotext copypast for extension
see scraed/CharacteristicGuidanceWebUI#1 AUTOMATIC1111/stable-diffusion-webui-extensions#253 (comment)
Checklist: