Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement general forward method for all method in built-in lora ext #14547

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

KohakuBlueleaf
Copy link
Collaborator

Description

For efficiency in lora-block-weight extension. We want to use old lora implementation (the bypass-forward one). But LyCORIS method doesn't support it at all.

Since not all the lyco method can implement efficient forward method. (And some of it is super tricky)
I decide to add general forward at first so at least it will not cause any error and still give out reasonable result.

Method specific implementation (for OFT and LoKr and GLoRA) will in the future PR.

Checklist:

@KohakuBlueleaf KohakuBlueleaf changed the base branch from master to dev January 5, 2024 08:37
@KohakuBlueleaf
Copy link
Collaborator Author

BTW I change the module in networks.py to org_module since in same function we have a loop to go through all the loras but use "module" for the lora module we are looking at.
So I change the "original module" to org_module.

I think this is better (then change "lora module" to lora_module)

@AUTOMATIC1111 AUTOMATIC1111 merged commit a4ee640 into dev Jan 6, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the lyco-forward branch January 6, 2024 07:50
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants