-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more Hr button fix #14626
more Hr button fix #14626
Conversation
On my side it doesn't serve black images already - it updates the gallery. As for As for returning multiple images - this kind of breaks |
strange 2024-01-12.16_31_31_911.chrome.mp4
yes I know there are other things that use gen info no need of having a separate fields thing reuse seed form |
seems to have found the fix for the black image issue otherwise the check file not found stable-diffusion-webui/modules/ui_tempdir.py Lines 34 to 37 in cb5b335
I guess you have shared.opts.save_images_add_number enabled and so don;t have this issue
|
Ah. That's a bug. I'll try and fix that. |
I got upcoming commits to fix the bug |
96e3a8b
to
02bd625
Compare
add p.txt2img_upscale as indicator
Description
some more fixes to hires fix button
makes no sense to save first pass image again
this allows the user to perform Hr on multiple images from a first pass batch
this is basically just for compatibility with my extension https://github.com/w-e-w/sd-webui-hires-fix-tweaks which allows you to generate multiple hr pass images
p.txt2img_upscale
attribute as indicator of usingtxt2img_upscale()
note commit parse_generation_parameters skip_fields from
example
first pass of 2 images
select 1st image (not counting the grid) for hr pass (with hr batch count of 3 using my extension)
job finished and and retruns / updates the 1st image with 3 new hr pass images
#14645
I made a PR for geninfo from Infotexts (the sutff below)
PR #14645 will merge in order for the multiple image returning to work, otherwise when saving or retrieving seed info will be wrong
Request
can
connect_reuse_seed()
be be changed to fetch information fromelem_id=f'generation_info_{self.tabname}'
tof'html_info_{self.script.tabname}
parse the info text as opposed the hidden jsonstable-diffusion-webui/modules/processing_scripts/seed.py
Lines 80 to 83 in cf2772f
example can be seen with what I did in my extension
https://github.com/w-e-w/sd-webui-hires-fix-tweaks/blob/3f9254ffb2d49f52e80989737dbb8c3bdbce445f/hires_fix_tweaks/ui.py#L13-L28
the reason being that remove the need of updating all the other geninfo parameters to just updateing the
infotext
when an extension wishes to return extra images
otherwise the following code (and possibly some more logic) needs to be added too the PR too make
allowe to return multiple images
properly workI believe this simplification applies to not just my extension
and I don't really see advantage of doing it the current way with the hidden json
I can make a PR if you agree, if you don't then this PR probably needs the above code added
Checklist: