Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove script callbacks in ordered_callbacks_map #15428

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

v0xie
Copy link
Contributor

@v0xie v0xie commented Apr 1, 2024

Description

  • This PR fixes script callbacks persisting after script_callbacks.remove_current_script_callbacks() is called. This would cause unexpected behavior by having extension callbacks not update in subsequent runs.

  • The problem was that remove_callbacks() did not remove callbacks from ordered_callbacks_map dict. We iterate through ordered_callbacks_map like callbacks_map to remove the script's callbacks.

  • The bug was introduced in commit 7e5e673.

Screenshots/videos:

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0cb2bbd into AUTOMATIC1111:dev Apr 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants