Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReloadUI backgroundColor --background-fill-primary #15864

Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented May 22, 2024

Description

during ReloadUI the webpage will true white regardless of dark or light mode
it's blindly annoying
this PR sets the backgroud color of the HTML body to the color defined by the theme --background-fill-primary

the body background color will be automatically removed by gradio once the page reloads
so no impact to anything else

note this solution is not a perfect soultion as during reload the page might still flash white for a brief period
but it is still better than constantly white during reload

Screenshots/videos:

2024-05-22 22_18_41_280 chrome

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner May 22, 2024 14:18
@Turkinolith
Copy link

+1 in support of this!

@AUTOMATIC1111 AUTOMATIC1111 merged commit e21b1e3 into dev Jun 8, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the ReloadUI-backgroundColor---background-fill-primary branch June 8, 2024 06:06
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants