Ensure use of python from venv on Mac and Linux #16116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user sets the full path to the Python executable in webui-user.sh, venv will be created as usual. Everything will work and look normal, but all packages will be actually installed globally.
It fixes #16113
The reason for this behavior is that in this line
python_cmd contains the full path and will be executed as
instead of
This change ensures that the python executable from venv will be used, even if the user sets the full path. This change only affects users who use venv; it does not change anything if venv is not used.
Screenshots/videos:
Checklist: