Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] do not break progressbar on non-job actions (add wrap_gradio_call_no_job) #16202

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Jul 12, 2024

Description

This PR fixes an annoying bug:

  1. Start batch processing
  2. Go to settings (even it different browser tab)
  3. Click "Apply Settings", or other little functions like "save zip"
  4. Progressbar is broken until the generation end

The better function name would be wrap_gradio_call and rename old to wrap_gradio_job, but it will break an interface for extensions

Checklist:

@light-and-ray
Copy link
Contributor Author

light-and-ray commented Jul 12, 2024

But maybe the better naming wont break anything, because wrap_gradio_call (with no gpu) with meaning it will use progress bar appears very-very rare. In vanilla only on extensions list loading from remote, I think extensions doesn't use it at all

Panchovix pushed a commit to Panchovix/stable-diffusion-webui-reForge that referenced this pull request Jul 13, 2024
@AUTOMATIC1111 AUTOMATIC1111 merged commit 7c8a4cc into AUTOMATIC1111:dev Jul 20, 2024
3 checks passed
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants