Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onSelect prop to Dropdown component #215

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

AVGVSTVS96
Copy link
Owner

Allows passing onSelect as a prop so it can be defined where the Dropdown is used. Defaults to navigate via window.location.href unless onSelect is defined.

Copy link

cloudflare-workers-and-pages bot commented Apr 20, 2024

Deploying astrosite with  Cloudflare Pages  Cloudflare Pages

Latest commit: b6382d2
Status: ✅  Deploy successful!
Preview URL: https://b1811ed5.astrosite-aid.pages.dev
Branch Preview URL: https://onselectdropdown.astrosite-aid.pages.dev

View logs

Copy link

codesandbox bot commented Apr 20, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Allows passing `onSelect` as a prop so it can be defined where the Dropdown is used. Defaults to navigate via `window.location.href` unless `onSelect` is defined.
Copy link
Owner Author

AVGVSTVS96 commented Apr 20, 2024

Merge activity

  • Apr 19, 11:21 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Apr 19, 11:22 PM EDT: @AVGVSTVS96 merged this pull request with Graphite.

@AVGVSTVS96 AVGVSTVS96 merged commit cdd5db5 into master Apr 20, 2024
1 check passed
@AVGVSTVS96 AVGVSTVS96 deleted the onSelectDropdown branch April 22, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant