Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(MDLayout.astro): Separate image handling and schema to their own util files #405

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

AVGVSTVS96
Copy link
Owner

@AVGVSTVS96 AVGVSTVS96 commented Jun 7, 2024

  • Separate image handling logic into new util file
    • Create imageHandler.ts util to use in MDLayout.astro. Exports const images and getImageURL function.
  • Generate blog jsonLD in it's own generateBlogSchema util file
    • Remove getImageUrl from imageHandler because it's only needed in generateBlogSchema
    • Update MDLayout to use generateBlogSchema util

Create `imageHandler.ts` util to use in `MDLayout.astro`. Exports `const images` and `getImageURL` function.
Remove `getImageUrl` from `imageHandler` because it's only needed in `generateBlogSchema`, Update `MDLayout` to use `generateBlogSchema` util
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024

Deploying astrosite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6e077c9
Status: ✅  Deploy successful!
Preview URL: https://df9dca53.astrosite-aid.pages.dev
Branch Preview URL: https://refactormdlayout-bas-127.astrosite-aid.pages.dev

View logs

Copy link

codesandbox bot commented Jun 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

linear bot commented Jun 7, 2024

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AVGVSTVS96 and the rest of your teammates on Graphite Graphite

@AVGVSTVS96 AVGVSTVS96 changed the title Separate image handling logic into new util file refactor(MDLayout.astro): Separate image handling and schema to their own util files Jun 7, 2024
@AVGVSTVS96 AVGVSTVS96 marked this pull request as ready for review June 7, 2024 16:30
@AVGVSTVS96 AVGVSTVS96 merged commit 88a97d0 into master Jun 7, 2024
1 check passed
@AVGVSTVS96 AVGVSTVS96 deleted the refactorMdLayout-BAS-127 branch June 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant