Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(CommandMenu): Modularize and update prop name #492

Merged
merged 1 commit into from
Jul 7, 2024
Merged

refactor(CommandMenu): Modularize and update prop name #492

merged 1 commit into from
Jul 7, 2024

Conversation

AVGVSTVS96
Copy link
Owner

  • Update the posts prop name to sortedPosts, update in header.astro
  • Refactor CommandMenu
    • Separate settings group to its own component, call theme hook within it.
    • Use arrow functions for components and integrate type interface directly in the component.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2024 •
edited
Loading

Deploying astrosite with  Cloudflare Pages  Cloudflare Pages

Latest commit: 20abc05
Status:⚡️  Build in progress...

View logs

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jul 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@AVGVSTVS96 Graphite App
Copy link
Owner Author

AVGVSTVS96 commented Jul 7, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AVGVSTVS96 and the rest of your teammates on Graphite Graphite

@AVGVSTVS96 AVGVSTVS96 mentioned this pull request Jul 7, 2024
Merged
@AVGVSTVS96 AVGVSTVS96 marked this pull request as ready for review July 7, 2024 03:15
@AVGVSTVS96 Graphite App
Copy link
Owner Author

AVGVSTVS96 commented Jul 7, 2024 •
edited
Loading

Merge activity

  • Jul 6, 11:28 PM EDT: @AVGVSTVS96 started a stack merge that includes this pull request via Graphite.
  • Jul 6, 11:31 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 6, 11:32 PM EDT: @AVGVSTVS96 merged this pull request with Graphite.

@AVGVSTVS96 AVGVSTVS96 changed the base branch from useHotKeysHook to master July 7, 2024 03:29
@AVGVSTVS96
refactor(CommandMenu): Modularize and update prop name
20abc05 
- Update the `posts` prop name to `sortedPosts`, update in `header.astro`
- Refactor `CommandMenu`
  - Separate settings group to its own component, call theme hook within it.
  - Use arrow functions for components and integrate type interface directly in the component.
@AVGVSTVS96 AVGVSTVS96 force-pushed the refactorCommandMenu branch from 7f3420f to 20abc05 Compare July 7, 2024 03:30
@AVGVSTVS96 AVGVSTVS96 merged commit 48d6fea into master Jul 7, 2024
1 check was pending
@AVGVSTVS96 AVGVSTVS96 deleted the refactorCommandMenu branch July 10, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AVGVSTVS96