Feature/877 add battery capacity fault capability #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Dec 20, 2024
src/simulation/power/simpleBattery/_UnitTest/test_simpleBatteryFault.py
Outdated
Show resolved
Hide resolved
src/simulation/power/simpleBattery/_UnitTest/test_simpleBatteryFault.py
Outdated
Show resolved
Hide resolved
|
@Yume27 , your pre-commit test failed. Be sure to install the pre-commit support by reading https://avslab.github.io/basilisk/Support/Developer/CodingGuidlines.html. Look near the bottom for the link to CONTRIBUTING.md. It talks about how to include the checks, and how to many force check specific files if needed. |
Yume27
force-pushed
the
feature/877-add-battery-capacity-fault-capability
branch
3 times, most recently
from
4f179b6 to
bf15fb5
Compare
juan-g-bonilla
approved these changes
Jan 21, 2025
Yume27
force-pushed
the
feature/877-add-battery-capacity-fault-capability
branch
from
bf15fb5 to
699dca5
Compare
schaubh
force-pushed
the
feature/877-add-battery-capacity-fault-capability
branch
from
699dca5 to
7216864
Compare
schaubh
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
I'm good with this PR now. I moved the commit that added the new fault message declaration to the top of the stack. Otherwise, if someone pulls an earlier commit the code would not compile.
Also added a minor fix to another script to address matplotlib warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This added the capability to simulate a fault in the
simpleBatterymodule that reduces the actual storage capacity without directly altering the stated capacity.Verification
Added unit test to verify that
Documentation
Updated rst file associated with simpleBattery module.
Future work
None