Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vizard 2.2.1 Support #894

Merged
merged 19 commits into from
Jan 16, 2025
Merged

Vizard 2.2.1 Support #894

merged 19 commits into from
Jan 16, 2025

Conversation

jackfox25
Copy link
Contributor

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Support for new features in Vizard release 2.2.1, including:

  • Rotating frame settings and documentation, highlighted in several existing example scenarios
  • Protobuffer library upgrade
  • vizProtobuffer module compiling with latest C++ compiler, rather than C++11
  • Other added documentation

Verification

Minimal functional code changes, no tests added or modified.

Documentation

None

Future work

Further documentation or change/refactor of vizInterface comm handshaking protocol

@jackfox25 jackfox25 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 8, 2025
@jackfox25 jackfox25 requested a review from schaubh January 8, 2025 19:16
@jackfox25 jackfox25 self-assigned this Jan 8, 2025
@jackfox25 jackfox25 requested a review from a team as a code owner January 8, 2025 19:16
schaubh
schaubh requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to add Jennifer's Vizard release notes to this branch.

docs/source/Support/bskReleaseNotes.rst Outdated Show resolved Hide resolved
@jackfox25 jackfox25 force-pushed the feature/viz_2_2_1 branch 4 times, most recently from 5e5525a to bddf1f5 Compare January 16, 2025 01:02
@jackfox25
Support for rotating frame settings
a671f5e
@jackfox25
Update rotating frame documentation
38ed9b1
@jackfox25
vizMessage.proto comment reformatting for readability (no content cha…
51d045b 
…nges)
@jackfox25
Add comment for body fixed frame setting
bacd54e
@jackfox25
Update vizInterface warning for trueTrajectoryLinesOn option
38c0779
@jackfox25
Implement Vizard frame views in select scenarios
5b7fae8
@jackfox25
Add documentation and images for osculating orbit lines and true traj…
e89265e 
…ectory lines
@jackfox25
Update select images with new view menu and start screen
073a330
@jackfox25
Typo correction
9893473
@jackfox25
Force vizProtobuffer to use same C++ compiler as BSK
57e11da
@jackfox25
Remove specific python protobuf library version
3267401
@jackfox25
Update custom shape model documentation for .glb support
941a456
@jackfox25
Document vizInterface port handshaking
059427a
@jackfox25
Add documentation for RGB depth map encoding fix
f45a352
@schaubh schaubh self-requested a review January 16, 2025 03:52
schaubh
schaubh approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@schaubh schaubh merged commit c830c43 into develop Jan 16, 2025
10 checks passed
@schaubh schaubh deleted the feature/viz_2_2_1 branch January 16, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaubh schaubh schaubh approved these changes

Assignees

@jackfox25 jackfox25

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Basilisk
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackfox25 @schaubh