Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logs from info dictionary #164

Closed
Mark2000 opened this issue Jul 24, 2024 · 0 comments · Fixed by #165
Closed

Remove logs from info dictionary #164

Mark2000 opened this issue Jul 24, 2024 · 0 comments · Fixed by #165
Assignees
@Mark2000
Labels
enhancement New feature or request

Comments

@Mark2000
Copy link
Contributor

Mark2000 commented Jul 24, 2024 •
edited
Loading

Including the logs breaks certain RL algorithms that expect a uniform format and shape for info dictionaries. Requires retaking should also be reported as a bool for each satellite (as opposed to a list of satellites that require it).

Also should deprecate log_info and log_warning, since satellite.logger.info serves the same purpose now.
@Mark2000 Mark2000 added the enhancement New feature or request label Jul 24, 2024
@Mark2000 Mark2000 self-assigned this Jul 24, 2024
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Reformat info dicts
6b717f0
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
b608eda
@Mark2000 Mark2000 mentioned this issue Jul 24, 2024
Merged
15 tasks
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Reformat info dicts
2d0351c
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
306f327
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
c25a830
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Reformat info dicts
f3af4ea
Mark2000 added a commit that referenced this issue Jul 24, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
817883d
Mark2000 added a commit that referenced this issue Jul 25, 2024
@Mark2000
Issue #164: Reformat info dicts
330254a
Mark2000 added a commit that referenced this issue Jul 25, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
e66d83a
Mark2000 added a commit that referenced this issue Jul 29, 2024
@Mark2000
Issue #164: Reformat info dicts
ca0638a
Mark2000 added a commit that referenced this issue Jul 29, 2024
@Mark2000
Issue #164: Deprecate log_info in favor of logger.info
e4dcaec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mark2000 Mark2000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up info dicts AVSLab/bsk_rl
1 participant
@Mark2000