Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public-facing documentation #17

Closed
4 of 7 tasks
Mark2000 opened this issue Jul 25, 2023 · 2 comments · Fixed by #140
Closed
4 of 7 tasks

Public-facing documentation #17

Mark2000 opened this issue Jul 25, 2023 · 2 comments · Fixed by #140
Assignees
Labels
documentation Improvements or additions to documentation infrastructure Testing, documentation, and CI system

Comments

@Mark2000
Copy link
Contributor

Mark2000 commented Jul 25, 2023

Goal: set up Sphinx docs for the repo

  • Use a basilisk docs-like style
  • Figure out best deployment strategy (support releases Determine release schedule #14 when we start doing that) and location (GitHub? Dr. Schaub's website?). More automated = better
  • Primary scope is generalized environment (bsk_rl/envs/general_satellite_tasking). Should be optimized for this (e.g. ingest Python type hints, which may make Convert docstrings to Sphinx style #78 unnecessary). Since other envs are going to be wrapped into the general env (Refactor specific environments to use general environment components #16), documentation is less important for them; instead consider a good way of documenting some baseline environments (which may include an associated refactor of where those examples should be)
  • The examples directory should be handled like examples in basilisk andother repos (rich formatted walkthrough of the code).
  • Make changelong page
  • Identify pages that need content written (home pages, examples, etc.)
  • Make bsk setters not private so that configs are documented, preferably expose defaults. Maybe rework system to have defaults in constructor and only decorate with names of fields?

If #79 would greatly change configuration of documentation, maybe we should do it first?

@Mark2000 Mark2000 added the documentation Improvements or additions to documentation label Jul 25, 2023
@Mark2000 Mark2000 added the infrastructure Testing, documentation, and CI system label Oct 31, 2023
@Mark2000 Mark2000 assigned Mark2000 and johnowagon and unassigned Mark2000 Nov 6, 2023
johnowagon added a commit that referenced this issue Dec 1, 2023
johnowagon added a commit that referenced this issue Dec 6, 2023
@johnowagon
Copy link
Contributor

I noticed many of the reStructuredText style docstrings that are currently in the repo contain syntax errors. There should be a newline after the summary section of the docstring. Im thinking this can be easily done using sed to change the docstrings using regex, thoughts on this approach?

@Mark2000
Copy link
Contributor Author

Mark2000 commented Dec 6, 2023

Sounds like a good plan. Would be nice to have a way of automatically checking docstring formatting, not sure if such a tool exists

johnowagon added a commit that referenced this issue Dec 11, 2023
Mark2000 pushed a commit that referenced this issue Dec 28, 2023
@Mark2000 Mark2000 assigned Mark2000 and unassigned johnowagon Dec 28, 2023
Mark2000 pushed a commit that referenced this issue Dec 29, 2023
Mark2000 pushed a commit that referenced this issue Dec 29, 2023
Mark2000 pushed a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 5, 2024
Mark2000 pushed a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 5, 2024
Mark2000 pushed a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 5, 2024
Mark2000 added a commit that referenced this issue Jan 23, 2024
Mark2000 pushed a commit that referenced this issue Jan 23, 2024
Mark2000 added a commit that referenced this issue Jan 23, 2024
Mark2000 pushed a commit that referenced this issue Jan 30, 2024
Mark2000 added a commit that referenced this issue Jan 30, 2024
Mark2000 pushed a commit that referenced this issue Jan 30, 2024
Mark2000 added a commit that referenced this issue Jan 30, 2024
Mark2000 pushed a commit that referenced this issue Jan 30, 2024
Mark2000 added a commit that referenced this issue Jan 30, 2024
@Mark2000 Mark2000 added this to the v1.0.0 Release milestone Mar 7, 2024
@Mark2000 Mark2000 mentioned this issue May 27, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation infrastructure Testing, documentation, and CI system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants