Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#45 nadir pointing science mode #62

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

LorenzzoQM
Copy link
Contributor

Description

Closes Issue #45

Added functions to perform Continuous Nadir Scanning. Now, if in imaging mode and within the attitude requirements, it will constantly store new data.

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

  • Python: [e.g. 3.11.5]
  • Basilisk: [e.g. 2.2.1]
  • Plaform: [MacOS 13.5.2]

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LorenzzoQM LorenzzoQM requested a review from Mark2000 September 14, 2023 21:42
@LorenzzoQM LorenzzoQM force-pushed the feature/#45-Nadir-pointing-science-mode branch from 72085ba to e0ba845 Compare September 15, 2023 16:11
Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Main points are to get rid of dependency on ImagingSatellite and other unused code; we want to keep things as lightweight and clean as possible!

Not gonna review tests until other changes since they will probably change in response.

bsk_rl/envs/general_satellite_tasking/scenario/data.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/scenario/data.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/scenario/data.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/scenario/data.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/scenario/data.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/simulation/fsw.py Outdated Show resolved Hide resolved
bsk_rl/envs/general_satellite_tasking/simulation/fsw.py Outdated Show resolved Hide resolved
@LorenzzoQM LorenzzoQM force-pushed the feature/#45-Nadir-pointing-science-mode branch 2 times, most recently from 2e87c2a to 591e0ba Compare September 19, 2023 16:56
@LorenzzoQM LorenzzoQM force-pushed the feature/#45-Nadir-pointing-science-mode branch from 591e0ba to e185f74 Compare September 20, 2023 16:18
@LorenzzoQM LorenzzoQM force-pushed the feature/#45-Nadir-pointing-science-mode branch from e185f74 to c939646 Compare September 20, 2023 17:00
@Mark2000
Copy link
Contributor

Change the name NadirImagingActions to NadirImagingAction for consistency with other single-action actions, then you're good to rebase into develop!

@LorenzzoQM LorenzzoQM force-pushed the feature/#45-Nadir-pointing-science-mode branch from c939646 to 25d9c11 Compare September 20, 2023 20:40
@LorenzzoQM LorenzzoQM merged commit 845e6b2 into develop Sep 20, 2023
8 checks passed
@LorenzzoQM LorenzzoQM deleted the feature/#45-Nadir-pointing-science-mode branch September 20, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants