-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#45 nadir pointing science mode #62
Conversation
72085ba
to
e0ba845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Main points are to get rid of dependency on ImagingSatellite and other unused code; we want to keep things as lightweight and clean as possible!
Not gonna review tests until other changes since they will probably change in response.
2e87c2a
to
591e0ba
Compare
591e0ba
to
e185f74
Compare
e185f74
to
c939646
Compare
Change the name |
c939646
to
25d9c11
Compare
Description
Closes Issue #45
Added functions to perform Continuous Nadir Scanning. Now, if in imaging mode and within the attitude requirements, it will constantly store new data.
How should this pull request be reviewed?
Type of change
How Has This Been Tested?
pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
Test Configuration
Checklist:
Issue #XXX: Message
and have a useful message