add ThrownExceptionNotInFunction rule to the Analyzer Plugin #585
+228
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #500 |
|
It's a draft. We can consider wider solution to warn when |
ddworak
requested changes
Jun 13, 2024
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInMonixScope.scala
Outdated
Show resolved
Hide resolved
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInMonixScope.scala
Outdated
Show resolved
Hide resolved
halotukozak
changed the title
…. The Scala compiler loves to infer Nothing as a generic type but that is almost always incorrect. Explicit type arguments should be used instead.
…her type. The Scala compiler loves to infer Nothing as a generic type but that is almost always incorrect. Explicit type arguments should be used instead." This reverts commit 9622a3f.
halotukozak
force-pushed
the
500-handle-thrown-exception-outside-the-monadic-context-of-task
branch
from
fffed2f to
ae2b07a
Compare
halotukozak
force-pushed
the
500-handle-thrown-exception-outside-the-monadic-context-of-task
branch
from
32644de to
0c3b54c
Compare
…side-the-monadic-context-of-task
…nadic-context-of-task
|
@ddworak Can we either proceed this MR or close it? |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new analyzer rule, ThrownExceptionNotInFunction, to detect cases where an exception is thrown directly as a function argument instead of wrapping it in a function literal. It includes:
- Implementation of the new analyzer rule scanning for thrown exceptions used in place of functions.
- Registration of the rule in the
AnalyzerPlugin. - Comprehensive tests covering method calls, constructors, multiple argument lists, and indirect exception-throwing scenarios.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInFunction.scala | Added the new rule class that reports thrown exceptions as function arguments. |
| analyzer/src/main/scala/com/avsystem/commons/analyzer/AnalyzerPlugin.scala | Registered the new ThrownExceptionNotInFunction rule in the plugin. |
| analyzer/src/test/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInFunctionTest.scala | Added unit tests for various call patterns to verify the rule’s behavior. |
Comments suppressed due to low confidence (1)
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInFunction.scala:6
- [nitpick] Consider adding a Scaladoc comment above this analyzer rule class to summarize its purpose and usage for future maintainers.
final class ThrownExceptionNotInFunction(g: Global) extends AnalyzerRule(g, "thrownExceptionNotInFunction") {
analyzer/src/main/scala/com/avsystem/commons/analyzer/AnalyzerPlugin.scala
Show resolved
Hide resolved
ddworak
requested changes
Jun 25, 2025
analyzer/src/main/scala/com/avsystem/commons/analyzer/ThrownExceptionNotInFunction.scala
Show resolved
Hide resolved
| } | ||
|
|
||
| test("Testing multiple arguments") { | ||
| assertErrors(26, |
There was a problem hiding this comment.
Debugging why an assertErrors(26, ... failed is impossible without editing the tests. Let's work on the developer experience in this test by using sth like org.scalatest.Inspectors in conjunction with assertErrors(1 and assertNoErrors (example, I'm sure you can suggest the best solution available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.