Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logics for editing and moving tasks, Update UI for tasks and Implement Import/Export #116

Merged
merged 12 commits into from
Oct 28, 2019

Conversation

jiayushe
Copy link

@jiayushe jiayushe commented Oct 27, 2019

@jiayushe jiayushe added this to the v1.3 milestone Oct 27, 2019
@jiayushe jiayushe self-assigned this Oct 27, 2019
@jiayushe jiayushe force-pushed the task branch 2 times, most recently from 2a9f094 to 447ab3b Compare October 27, 2019 19:28
@jiayushe jiayushe requested a review from le0tan October 27, 2019 19:34
@jiayushe jiayushe requested a review from tiuweehan October 28, 2019 06:04
@jiayushe jiayushe force-pushed the task branch 3 times, most recently from 64bbabc to 26227ae Compare October 28, 2019 06:42
@coveralls
Copy link

coveralls commented Oct 28, 2019

Pull Request Test Coverage Report for Build 305

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 499 unchanged lines in 36 files lost coverage.
  • Overall coverage decreased (-3.3%) to 36.185%

Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/Author.java 1 73.68%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/Description.java 1 75.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/Difficulty.java 1 56.52%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/Remark.java 1 75.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/Source.java 1 73.68%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/WebLink.java 1 68.18%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/commons/util/FileUtil.java 2 83.33%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/AddCommand.java 2 76.92%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/HelpCommand.java 2 91.67%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/DeleteCommand.java 3 58.33%
Totals Coverage Status
Change from base Build 296: -3.3%
Covered Lines: 1493
Relevant Lines: 4126

💛 - Coveralls

Copy link

@le0tan le0tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look into the UI part, otherwise looks good to me.

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/logic/Logic.java Show resolved Hide resolved
import seedu.algobase.storage.JsonSerializableAlgoBase;

/**
* Imports AlgoBase from specified location.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it true that by importing a save file AlgoBase will essentially overwrite the save file at its default location?
Is it better if we change the default save file path at the same time so that the old save file won't be overwritten?

@jiayushe jiayushe merged commit f73347c into AY1920S1-CS2103T-W11-1:master Oct 28, 2019
@jiayushe jiayushe changed the title Update Task and Storage Add logics for editing and moving tasks, Update UI for tasks and Implement Import/Export Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment