Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date exceptions #148

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Add date exceptions #148

merged 5 commits into from
Oct 30, 2019

Conversation

Seris370
Copy link

Also changes user guide.
fixes #142 #141 #139 #131

@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 339

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 91 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 33.658%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/searchrule/plansearchrule/TimeRange.java 7 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/AddPlanCommandParser.java 16 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/FindPlanCommandParser.java 19 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/EditPlanCommand.java 49 2.82%
Totals Coverage Status
Change from base Build 336: -0.04%
Covered Lines: 1487
Relevant Lines: 4418
💛 - Coveralls

@Seris370 Seris370 self-assigned this Oct 30, 2019
@Seris370 Seris370 requested a review from jiayushe October 30, 2019 13:44
jiayushe
jiayushe approved these changes Oct 30, 2019
View reviewed changes
Copy link

@jiayushe jiayushe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just remove the unnecessary changes.

docs/UserGuide.adoc Show resolved Hide resolved
src/main/java/seedu/algobase/logic/commands/task/AddTaskCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/model/task/Task.java Outdated Show resolved Hide resolved
@Seris370 Seris370 merged commit 8bd2098 into AY1920S1-CS2103T-W11-1:master Oct 30, 2019
@jiayushe jiayushe added this to the v1.4 milestone Oct 31, 2019
@nus-se-bot nus-se-bot mentioned this pull request Nov 5, 2019
Closed
17 tasks
This was referenced Nov 13, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayushe jiayushe jiayushe approved these changes

Assignees

@Seris370 Seris370

Labels
status.reviewRequired
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

No message returned when typing command 'findplan n/'
3 participants
@Seris370 @coveralls @jiayushe