Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UI and Fix Minor Bugs #164

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Update UI and Fix Minor Bugs #164

merged 3 commits into from
Oct 31, 2019

Conversation

jiayushe
Copy link

@jiayushe jiayushe commented Oct 31, 2019 •
edited
Loading

@jiayushe jiayushe requested review from tiuweehan and le0tan October 31, 2019 15:50
@jiayushe jiayushe self-assigned this Oct 31, 2019
@jiayushe jiayushe added this to the v1.4 milestone Oct 31, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 369

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 74 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.007%) to 33.464%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/TaskCard.java 3 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/plan/PlanList.java 9 32.2%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/TaskManagementPane.java 24 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/MainWindow.java 38 0.0%
Totals Coverage Status
Change from base Build 367: -0.007%
Covered Lines: 1538
Relevant Lines: 4596
💛 - Coveralls

@jiayushe jiayushe requested review from Seris370 and LuWenQ October 31, 2019 15:55
le0tan
le0tan approved these changes Oct 31, 2019
View reviewed changes
Copy link

@le0tan le0tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Can you update the release as well? Thx!

@jiayushe
Copy link
Author

Good job! Can you update the release as well? Thx!

I guess I will wait for @LuWenQ to fix #163 first.

@jiayushe jiayushe merged commit 74e4b5e into AY1920S1-CS2103T-W11-1:master Oct 31, 2019
@nus-se-bot nus-se-bot mentioned this pull request Nov 5, 2019
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le0tan le0tan le0tan approved these changes

@tiuweehan tiuweehan Awaiting requested review from tiuweehan

@Seris370 Seris370 Awaiting requested review from Seris370

@LuWenQ LuWenQ Awaiting requested review from LuWenQ

Assignees

@jiayushe jiayushe

Labels
status.reviewRequired
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Current plan will display null if AlgoBase is not loaded properly
3 participants
@jiayushe @coveralls @le0tan