Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and edit GUI #215

Merged
merged 20 commits into from
Nov 5, 2019

Conversation

tiuweehan
Copy link

@tiuweehan tiuweehan commented Nov 4, 2019

Fix #156
Fix #161
Fix #168
Fix #169
Fix #172
Fix #190
Fix #193
Fix #196

Make ProblemDetails and PlanDetails editable and deletable
Update UG and DG

@tiuweehan tiuweehan self-assigned this Nov 4, 2019
@tiuweehan tiuweehan added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Nov 4, 2019
@tiuweehan tiuweehan added this to the v1.4 milestone Nov 4, 2019
@coveralls
Copy link

coveralls commented Nov 4, 2019

Pull Request Test Coverage Report for Build 427

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 360 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-6.1%) to 48.103%

Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/ClearCommand.java 1 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/details/DetailsTabPane.java 3 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/details/DetailsTab.java 7 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/ModelManager.java 8 79.39%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/PlanListPanel.java 10 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/ProblemListPanel.java 12 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/LogicManager.java 14 58.82%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/plan/PlanList.java 15 75.64%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/ProblemCard.java 16 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/display/DisplayTabPane.java 17 0.0%
Totals Coverage Status
Change from base Build 423: -6.1%
Covered Lines: 2523
Relevant Lines: 5245

💛 - Coveralls

@tiuweehan tiuweehan requested a review from Seris370 November 5, 2019 09:12
@tiuweehan tiuweehan removed the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Nov 5, 2019
@tiuweehan tiuweehan merged commit 3433dd6 into AY1920S1-CS2103T-W11-1:master Nov 5, 2019
@tiuweehan tiuweehan deleted the edit-from-gui branch November 5, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants