Bug Fixes #166
Bug Fixes #166
Conversation
| @@ -114,6 +114,8 @@ public static void main(String[] args) { | |||
| c.execute(dietBook.manager, dietBook.ui); | |||
| } catch (DietException e) { | |||
| dietBook.ui.printErrorMessage(e.getMessage()); | |||
| } catch (Exception e) { | |||
| throw new DietException("Wrong command format!"); | |||
There was a problem hiding this comment.
Perhaps consider changing to a more generic message.
There was a problem hiding this comment.
I feel like this is super generic already because all the input are all "commands" so any typos should be safe to consider as a wrong format of command. "Something went wrong" is too vague of a message i feel? wdyt
There was a problem hiding this comment.
I see. I was thinking that since all the exceptions are being caught here it could also possibly be catching an error from elsewhere in the system other than the command input. However, if you think that only the command input is likely to result in an exception that is caught here I think you can leave it as such.
There was a problem hiding this comment.
Hmm runtime error and such rite,,,, orite i will just change it to Something went wrong cos i think we will be catching most of the exceptions for commands.
There was a problem hiding this comment.
Perhaps you can consider catching other possible generic exceptions that may be thrown like NumberFormatException, StringIndexOutOfBound, IOException before catching Exception so that more specific error messages can be output.
| } else if (age > AGE_CAP) { | ||
| throw new DietException("Input value cannot be more than 125!"); | ||
| throw new DietException("Age value cannot be more than 125!"); |
There was a problem hiding this comment.
Perhaps consider changing 125 to AGE_CAP or 150. You might like to consider this suggestion for the other methods as well.
- Specific exception messages
-Catching all exception
-Fixed for specific exceptions
-Fixed calculate rubbish acceptance
-Fixed name accepting empty/empty checker