Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Ui and add logging #170

Merged
merged 16 commits into from
Nov 6, 2020
Merged

Refactor Ui and add logging #170

merged 16 commits into from
Nov 6, 2020

Conversation

HengFuYuen
Copy link

@HengFuYuen HengFuYuen commented Nov 4, 2020 •
edited
Loading

Fixes #167
Fixes #168
Fixes #128

tikimonarch
tikimonarch approved these changes Nov 5, 2020
View reviewed changes
Copy link

@tikimonarch tikimonarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HengFuYuen HengFuYuen merged commit 7378bca into AY2021S1-CS2113-T14-4:master Nov 6, 2020
@HengFuYuen HengFuYuen mentioned this pull request Nov 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikimonarch tikimonarch tikimonarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logging for Ui Refactor Ui [PE-D] Entering Whitespace Crashes Program
2 participants
@HengFuYuen @tikimonarch