Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer guide #194

Merged
merged 16 commits into from
Nov 9, 2020
Merged

Developer guide #194

merged 16 commits into from
Nov 9, 2020

Conversation

HengFuYuen
Copy link

Fixes #193

0xEljh
0xEljh requested changes Nov 8, 2020
View reviewed changes
Copy link

@0xEljh 0xEljh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing your diagram file naming convention such that no spaces are in the name. This will allow it to be a valid URL that can be referenced by the dev guide. Current URL links look broken (can also be seen in the current dev guide).

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
0xEljh
0xEljh approved these changes Nov 8, 2020
View reviewed changes
Copy link

@0xEljh 0xEljh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HengFuYuen HengFuYuen marked this pull request as ready for review November 9, 2020 03:30
@HengFuYuen HengFuYuen merged commit 06dd83d into AY2021S1-CS2113-T14-4:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xEljh 0xEljh 0xEljh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update developer guide
2 participants
@HengFuYuen @0xEljh