Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some updates after meeting #56

Merged
merged 8 commits into from
Oct 25, 2021
Merged

Some updates after meeting #56

merged 8 commits into from
Oct 25, 2021

Conversation

Isabella-L
Copy link

@Isabella-L Isabella-L commented Oct 24, 2021 •
edited
Loading

Created:
commandfactory class
command interface & implementations

Updated Game to abstract

Solves #57

@Isabella-L Isabella-L requested a review from LimJiaJing October 24, 2021 18:57
@Isabella-L Isabella-L self-assigned this Oct 24, 2021
@Isabella-L Isabella-L added the priority.High Must do label Oct 24, 2021
@Isabella-L Isabella-L added this to the v2.0 milestone Oct 24, 2021
LimJiaJing
LimJiaJing approved these changes Oct 25, 2021
View reviewed changes
Copy link

@LimJiaJing LimJiaJing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved OOP design overall.
Better SLAP implementation in Main.
Good implementation of Design factory.
Overall less coupling and higher cohesion.

@LimJiaJing LimJiaJing merged commit e94958e into AY2122S1-CS2113-T13-4:master Oct 25, 2021
@Isabella-L Isabella-L linked an issue Oct 27, 2021 that may be closed by this pull request
Update Parser to use factory Pattern #57
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimJiaJing LimJiaJing LimJiaJing approved these changes

Assignees

@Isabella-L Isabella-L

Labels
priority.High Must do
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Update Parser to use factory Pattern
2 participants
@Isabella-L @LimJiaJing