Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix note check for lower case #134

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

Woolicious98
Copy link
Collaborator

No description provided.

@Woolicious98 Woolicious98 added the type.Bug A bug label Oct 26, 2021
@Woolicious98 Woolicious98 added this to the v2.0 milestone Oct 26, 2021
@Woolicious98 Woolicious98 self-assigned this Oct 26, 2021
@kelvneo kelvneo added the severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. label Oct 26, 2021
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #134 (b9cf485) into master (1ab51f6) will increase coverage by 1.67%.
The diff coverage is 96.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #134      +/-   ##
============================================
+ Coverage     75.38%   77.06%   +1.67%     
- Complexity      408      423      +15     
============================================
  Files            56       56              
  Lines          1292     1308      +16     
  Branches        140      144       +4     
============================================
+ Hits            974     1008      +34     
+ Misses          215      203      -12     
+ Partials        103       97       -6     
Impacted Files Coverage Δ
src/main/java/terminus/common/CommonFormat.java 66.66% <ø> (ø)
src/main/java/terminus/common/Messages.java 66.66% <ø> (ø)
src/main/java/terminus/storage/ModuleStorage.java 78.92% <90.00%> (+9.69%) ⬆️
src/main/java/terminus/command/GoCommand.java 88.23% <100.00%> (ø)
.../terminus/command/content/link/AddLinkCommand.java 88.88% <100.00%> (+0.88%) ⬆️
...java/terminus/command/module/AddModuleCommand.java 80.76% <100.00%> (+0.76%) ⬆️
...a/terminus/command/module/UpdateModuleCommand.java 94.11% <100.00%> (+0.17%) ⬆️
src/main/java/terminus/content/ContentManager.java 93.33% <100.00%> (ø)
src/main/java/terminus/module/ModuleManager.java 100.00% <100.00%> (ø)
src/main/java/terminus/common/CommonUtils.java 82.25% <0.00%> (+1.61%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa15cf6...b9cf485. Read the comment docs.

Copy link
Collaborator

@3m0W33D 3m0W33D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Woolicious98 Woolicious98 merged commit cae03ce into AY2122S1-CS2113T-T10-2:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants