Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DG #318

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Update DG #318

merged 6 commits into from
Apr 15, 2024

Conversation

ParthGandhiNUS
Copy link

Update DG

@ParthGandhiNUS ParthGandhiNUS added the documentation Improvements or additions to documentation label Apr 15, 2024
@ParthGandhiNUS ParthGandhiNUS self-assigned this Apr 15, 2024
tayponghee
tayponghee requested changes Apr 15, 2024
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
tayponghee
tayponghee approved these changes Apr 15, 2024
View reviewed changes
docs/DeveloperGuide.md

#### 2. Adding single or multiple subjects to an existing student
1. Prerequisites: Add student 'tim' and initiate edit mode for 'tim'.
2. Test Case: `1`, `CS2113`, `11`, `1`, `no`
<br/> Expected: 'tim' has subject 'CS2113' with marks '11' and '1' class attended.
Expected: 'tim' has subject 'CS2113' with marks '11' and '1' class attended.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

docs/DeveloperGuide.md Outdated
5. Test Case: `4`, `11111111`
</br> Expected: Prints invalid phone number error message and prompts for another phone number.
Expected: Prints invalid phone number error message and prompts for another phone number.
6. Test Case: `6`, `20 jan 2001`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to test case 5

@tayponghee tayponghee merged commit 8314fa7 into AY2324S2-CS2113-T13-3:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tayponghee tayponghee tayponghee approved these changes

@blackmirag3 blackmirag3 Awaiting requested review from blackmirag3

@Cryolian Cryolian Awaiting requested review from Cryolian

@alalal47 alalal47 Awaiting requested review from alalal47

Assignees

@ParthGandhiNUS ParthGandhiNUS

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParthGandhiNUS @tayponghee