Add Subject to Lesson.java #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/seedu/address/logic/parser/CliSyntax.java
estellelim
approved these changes
Nov 1, 2024
| @@ -27,7 +29,7 @@ public class AddLessonCommand extends Command { | |||
| + ": Adds a lesson taught by the tutor to the tutee identified by their respective index numbers " | |||
| + "in the displayed persons list.\n" | |||
| + "Parameters: TUTORINDEX TUTEEINDEX (must be positive integers)\n" | |||
There was a problem hiding this comment.
Update the command description and format (and use TUTOR_INDEX etc)
| @@ -26,23 +28,35 @@ public class DeleteLessonCommand extends Command { | |||
| + ": Deletes the lesson between a tutor and tutee, identified by their respective index numbers " | |||
| + "in the displayed person list.\n" | |||
| + "Parameters: TUTORINDEX TUTEEINDEX (must be positive integers)\n" | |||
| + "Example: " + COMMAND_WORD + " 1 3"; | |||
| + "Example: " + COMMAND_WORD + " 1 3" + " " + PREFIX_SUBJECT + "Math"; | |||
There was a problem hiding this comment.
Update the command description, parameters and JavaDoc
| /** | ||
| * Creates a DeleteLesson Command to delete the Lesson asssociated with | ||
| * the specified {@code Tutor} and {@code Tutee}. | ||
| * @param tutorIndex | ||
| * @param tuteeIndex | ||
| */ | ||
| public DeleteLessonCommand(Index tutorIndex, Index tuteeIndex) { | ||
| public DeleteLessonCommand(Index tutorIndex, Index tuteeIndex, Subject subject) { |
| * @throws ParseException if the specified index is invalid (not non-zero unsigned integer) | ||
| * or if the format was wrong. | ||
| */ | ||
| public static Index[] parseIndexes(String args) throws ParseException { |
There was a problem hiding this comment.
Remove parseIndices if not used anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104
fixes #105
TODO:
The DeleteLessonCommand.java class is not updated with the discussed command format