Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the Listing Commands back to using Index #275

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

lrongyi
Copy link

@lrongyi lrongyi commented Nov 7, 2024

Change logic and parsing for all Listing Commands that previously used Name.

@lrongyi lrongyi added the priority.High Must do label Nov 7, 2024
@lrongyi lrongyi requested a review from wang-h-z November 7, 2024 17:45
@lrongyi lrongyi self-assigned this Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/commands/listingcommands/EditListingCommand.java 88.46% 1 Missing and 2 partials ⚠️
...ic/commands/listingcommands/AddListingCommand.java 91.66% 0 Missing and 2 partials ⚠️
...nds/listingcommands/AddBuyersToListingCommand.java 95.45% 0 Missing and 1 partial ⚠️
...commands/listingcommands/DeleteListingCommand.java 88.88% 0 Missing and 1 partial ⚠️
...istingcommands/RemoveBuyersFromListingCommand.java 96.15% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
...n/java/seedu/address/commons/core/index/Index.java 100.00% <100.00%> (ø) 14.00 <1.00> (+1.00)
src/main/java/seedu/address/logic/Messages.java 93.75% <ø> (ø) 4.00 <0.00> (ø)
...ommandparsers/AddBuyersToListingCommandParser.java 100.00% <100.00%> (ø) 6.00 <0.00> (+1.00)
...listingcommandparsers/AddListingCommandParser.java 94.73% <100.00%> (+0.98%) 5.00 <0.00> (+1.00)
...tingcommandparsers/DeleteListingCommandParser.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...istingcommandparsers/EditListingCommandParser.java 92.00% <100.00%> (-8.00%) 8.00 <0.00> (-1.00)
...dparsers/RemoveBuyersFromListingCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...nds/listingcommands/AddBuyersToListingCommand.java 97.72% <95.45%> (-2.28%) 12.00 <1.00> (-1.00)
...commands/listingcommands/DeleteListingCommand.java 94.11% <88.88%> (-5.89%) 6.00 <1.00> (ø)
...istingcommands/RemoveBuyersFromListingCommand.java 98.00% <96.15%> (-2.00%) 14.00 <2.00> (+1.00) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

@wang-h-z wang-h-z merged commit 6987a39 into AY2425S1-CS2103T-F11-4:master Nov 8, 2024
6 of 7 checks passed
Copy link

@wang-h-z wang-h-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Cutting it close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants