Add functionality for uploading profile picture #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlphaPyke
reviewed
Oct 27, 2024
|
|
||
| /** | ||
| * Default constructor for a UploadCommand object | ||
| * @param targetIndex Index to be deleted |
There was a problem hiding this comment.
is this "deleted" because the target will be replaced?
There was a problem hiding this comment.
Nope, typo on my end. Will change to be "uploaded"
Justin-Aw46
reviewed
Oct 31, 2024
Comment on lines
+63
to
+78
| //adapted from https://stackoverflow.com/questions/19302029/filter-file-types-with-jfilechooser | ||
| // fileChooser.setFileFilter(new FileFilter() { | ||
| // | ||
| // public String getDescription() { | ||
| // return "PNG Images (*.png)"; | ||
| // } | ||
| // | ||
| // public boolean accept(File f) { | ||
| // if (f.isDirectory()) { | ||
| // return true; | ||
| // } else { | ||
| // String filename = f.getName().toLowerCase(); | ||
| // return filename.endsWith(".png"); | ||
| // } | ||
| // } | ||
| // }); |
There was a problem hiding this comment.
Do you need this part? If not could delete it since its commented out.
|
LGTM, I will take over from here. |
AlphaPyke
merged commit 30df9c1
into
AY2425S1-CS2103T-F14b-4:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Closes #86