Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in deletetag command #171

Merged

Conversation

leroychiu20
Copy link

No description provided.

@leroychiu20 leroychiu20 changed the title Fix bugs in deletetag and tag commands Fix bugs in deletetag command Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 5 Missing ⚠️
...va/seedu/address/model/person/company/Company.java 71.42% 0 Missing and 2 partials ⚠️
...va/seedu/address/model/person/student/Student.java 83.33% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 90.62% <ø> (ø) 7.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 97.36% <100.00%> (+0.30%) 17.00 <2.00> (+1.00)
...seedu/address/logic/commands/DeleteTagCommand.java 93.02% <100.00%> (+0.52%) 13.00 <0.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...eedu/address/logic/commands/HelpWindowCommand.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 87.09% <100.00%> (+0.43%) 18.00 <0.00> (+1.00)
...ain/java/seedu/address/logic/parser/CliSyntax.java 88.88% <100.00%> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/model/person/Name.java 92.85% <ø> (ø) 6.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 56.25% <ø> (-2.09%) 9.00 <0.00> (-3.00)
... and 4 more

... and 10 files with indirect coverage changes

@leroychiu20 leroychiu20 added this to the v1.5 milestone Nov 5, 2024
@limjeremy496
Copy link

LGTM!

@limjeremy496 limjeremy496 merged commit 95bb2fd into AY2425S1-CS2103T-T14-2:master Nov 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants