Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #352

Merged

Conversation

gladwintan
Copy link

No description provided.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...logic/commands/MarkAttendanceByStudentCommand.java 86.36% <ø> (ø) 18.00 <0.00> (ø)
...c/parser/MarkAttendanceByStudentCommandParser.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
.../parser/MarkAttendanceByTutorialCommandParser.java 92.85% <ø> (ø) 4.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 68.42% <ø> (ø) 26.00 <0.00> (ø)
...in/java/seedu/address/model/person/Attendance.java 75.00% <ø> (ø) 9.00 <0.00> (ø)
src/main/java/seedu/address/ui/AttendanceCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ain/java/seedu/address/ui/AttendanceContainer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PaymentCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/PersonListPanel.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

Copy link

@Slipperybara Slipperybara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Slipperybara Slipperybara merged commit cfe347c into AY2425S1-CS2103T-W08-2:master Nov 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants