Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counting of hidden entities and devices #157

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix counting of hidden entities and devices #157

wants to merge 7 commits into from

Conversation

w531t4
Copy link
Contributor

@w531t4 w531t4 commented Nov 17, 2024 •
edited
Loading

  • PR excludes any entity/device hidden by the user from being counted in chips/views
  • Copied logic used to mask entities from being displayed into the logic responsible for counting entities

Fixes #159

@DigiLive
Copy link
Collaborator

On hold...
Needs some further investigation from my side.

@w531t4
Copy link
Contributor Author

w531t4 commented Nov 24, 2024

On hold... Needs some further investigation from my side.

understood. If there's any legwork i can do/prove to assist, please let me know.

@DigiLive
Copy link
Collaborator

DigiLive commented Nov 25, 2024 •
edited
Loading

On hold... Needs some further investigation from my side.

understood. If there's any legwork i can do/prove to assist, please let me know.

The fix involves some more code changes.
I'm gonna push some changes one by one which I would like you to test carefully.
After you confirm the code's valid, I will push the next change to test.

Note

Don't push any of your changes to this branch in the meanwhile!

@w531t4 Can you validate the latest push, please?

@DigiLive
Refactor filter logic
9c3d85e 
Moved the filter-logic for entities, hidden by the strategy options,
from `getCountTemplate()` to `#areaFilterCallback()`.
@DigiLive DigiLive self-assigned this Nov 25, 2024
@w531t4
Copy link
Contributor Author

w531t4 commented Nov 29, 2024

On hold... Needs some further investigation from my side.

understood. If there's any legwork i can do/prove to assist, please let me know.

The fix involves some more code changes. I'm gonna push some changes one by one which I would like you to test carefully. After you confirm the code's valid, I will push the next change to test.

Note

Don't push any of your changes to this branch in the meanwhile!

@w531t4 Can you validate the latest push, please?

@DigiLive validated. confirmed functional.

@DigiLive
Refactor exclusion of hidden sensor-entities
3cda99b 
Evaluation an entity's hidden property in the strategy options, is now
included in Helper.#areaFilterCallback(). Therefore, it's cut from the
callback for importing domainCards.
@DigiLive
Copy link
Collaborator

@w531t4 Please validate again.
This commit involves excluding hidden entities from the different area views.

@DigiLive DigiLive added bug Something isn't working Needs Feedback Something needs clarification or a response is expected labels Nov 29, 2024
@DigiLive DigiLive mentioned this pull request Nov 30, 2024
Draft
@DigiLive
Refactor exclusion of hidden misc. entities
3e85c60 
Evaluation an entity's hidden property in the strategy options, is now
included in Helper.#areaFilterCallback(). Therefore, it's cut from the
callback for importing domainCards.
@w531t4
Copy link
Contributor Author

w531t4 commented Dec 2, 2024

@w531t4 Please validate again. This commit involves excluding hidden entities from the different area views.

@DigiLive i've tested behavior in climate/lights views. looks fine.

@DigiLive
Copy link
Collaborator

DigiLive commented Dec 2, 2024

@w531t4 Please validate again.
This commit involves excluding hidden miscellaneous entities from the different area views.

@DigiLive
Copy link
Collaborator

@w531t4 Can you confirm the latest commit is still ok?

@w531t4 Please validate again. This commit involves excluding hidden miscellaneous entities from the different area views.

@w531t4 Can you confirm the latest commit is as expected?

@DigiLive DigiLive self-requested a review December 13, 2024 06:38
@DigiLive DigiLive added this to the Release v2.2.0 milestone Dec 14, 2024
@DigiLive DigiLive added the In Progress Someone is already working on it. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigiLive DigiLive Awaiting requested review from DigiLive

At least 1 approving review is required to merge this pull request.

Assignees

@DigiLive DigiLive

Labels
bug Something isn't working In Progress Someone is already working on it. Needs Feedback Something needs clarification or a response is expected
Projects
None yet
Milestone
Release v2.2.0
Development

Successfully merging this pull request may close these issues.

Hidden entities still counted at chips and controller card
2 participants
@w531t4 @DigiLive