Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BinarySensorCard to use Mushroom Chips card with default configuration #160

Closed
wants to merge 3 commits into from

Conversation

dipseth
Copy link

@dipseth dipseth commented Nov 19, 2024

No description provided.

@dipseth
Copy link
Author

dipseth commented Nov 19, 2024

Update Binary Sensor to use Chips card in Area Views, allowing native icons to be seen in the dashboard:

image

@dipseth
Copy link
Author

dipseth commented Nov 19, 2024

FYI:

The third Chip, first column second row, is the result of a card option overriding the default. This is why it isn't green, though it is in an on state.

Part of my config

  card_options:
    binary_sensor.office_radar:
      type: custom:mushroom-chips-card
      chips:
        - type: entity
          entity: binary_sensor.office_radar

@DigiLive DigiLive self-requested a review November 20, 2024 06:00
@DigiLive
Copy link
Collaborator

Firstly, thank you for your effort.

I need some more context.
If the goal is to show the "native" icons at a binary sensor card, we can accomplish this by changing the current default icon.
This can be tested by setting a card option, E.g.:

    card_options:
      binary_sensor.beweging_keuken_beweging:
        icon: null

If the goal is to change the entire appearance of the card so it looks like a chip, then we need to redefine the binary sensor class indeed.

@dipseth Please inform me about you actual goal.

@DigiLive DigiLive self-assigned this Nov 22, 2024
@DigiLive DigiLive added enhancement New feature or request Needs Feedback Something needs clarification or a response is expected labels Nov 22, 2024
@dipseth
Copy link
Author

dipseth commented Nov 23, 2024

Firstly, thank you for your effort.

I need some more context. If the goal is to show the "native" icons at a binary sensor card, we can accomplish this by changing the current default icon. This can be tested by setting a card option, E.g.:

    card_options:
      binary_sensor.beweging_keuken_beweging:
        icon: null

If the goal is to change the entire appearance of the card so it looks like a chip, then we need to redefine the binary sensor class indeed.

@dipseth Please inform me about you actual goal.

I was having a hard time distinguishing all the different binary sensors without the icon, and repeating the card_options entry for every single binary sensor was not practical for me. I usually would just use card mod, but that didn't seem to work here as there was no obvious way to adjust to style for all these entites dynamically.

So I would my motivation was definitely the latter as I think the chips card makes it slot easier to see information I'm look for faster in the area views.

@DigiLive DigiLive removed the Needs Feedback Something needs clarification or a response is expected label Nov 23, 2024
@DigiLive
Copy link
Collaborator

DigiLive commented Nov 24, 2024

Caution

Do not commit any changes to this Pull Request until further notice.
Until the discussion below has been resolved, this conversation is locked.

@AalianKhan What's your opinion in the appearance matter?
IMHO For the binary sensors, the chipscard appearance is a bit out of context with the appearances of the other cards since they are smaller and indicating the on state by icon/icon-color only.
I'm OK with changing the default icon.

(I think the chipscard is more ideal for scenes, as suggested at #164).

image
versus
image

If we agree on accepting the chipscard appearance, we must decide on changing the current appearance or to add the chipscard as an alternative appearance for binary sensors.

Repository owner locked and limited conversation to collaborators Nov 24, 2024
@DigiLive DigiLive added the Needs Feedback Something needs clarification or a response is expected label Nov 24, 2024
@AalianKhan
Copy link
Owner

Hey Dipseth, Thanks for your efforts!
IMO, the current appearance of the card looks decent. Just having binary sensors look different looks a bit odd to me and destroys the continuity.

I think the best way forward is to add an option under the domain option where the user can define their card style for a set domain. That way the user has control over how any domain looks which may result in some creative dashboards that auto-generate which is one of my main goals with this project.

Repository owner unlocked this conversation Dec 13, 2024
@DigiLive DigiLive removed the Needs Feedback Something needs clarification or a response is expected label Dec 13, 2024
@DigiLive
Copy link
Collaborator

I'll see if I can introduce a chipscard for the benefit of #135 (Request 1).
Involves PR #164.

From there we can see if we can offer the chipscard as an alternative appearance for entities.

@DigiLive DigiLive closed this Dec 13, 2024
@DigiLive DigiLive removed their request for review December 13, 2024 11:49
@DigiLive DigiLive removed their assignment Dec 13, 2024
@DigiLive DigiLive added the wont do This will not be worked on label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wont do This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants