fix: pin momentjs version as some date parsing (or tests) are failing

in DateImportConfigComponent
Aam-Digital · Mar 21, 2024 · 0b6dd33 · 0b6dd33
1 parent 822b448
commit 0b6dd33
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -54,7 +54,7 @@
     "leaflet": "^1.9.4",
     "lodash-es": "^4.17.21",
     "md5": "^2.3.0",
-    "moment": "^2.29.4",
+    "moment": "2.29.4",
     "ngx-markdown": "^17.1.1",
     "ngx-papaparse": "^8.0.0",
     "pouchdb-adapter-memory": "^8.0.1",

diff --git a/src/app/core/basic-datatypes/date/date-import-config/date-import-config.component.ts b/src/app/core/basic-datatypes/date/date-import-config/date-import-config.component.ts
@@ -57,6 +57,7 @@ export class DateImportConfigComponent {
   checkDateValues() {
     this.format.setErrors(undefined);
     this.values.forEach((val) => {
+      // TODO: check and improve the date parsing. Tests fail with moment.js > 2.29
       const date = moment(val.value, this.format.value?.toUpperCase(), true);
       if (date.isValid()) {
         val.parsed = date.toDate();