refactor: Remove ComponentFactoryResolver (#1401)

Co-authored-by: Simon <simon@aam-digital.com>
Aam-Digital · Aug 23, 2022 · 46fa295 · 46fa295
1 parent 8d4aedf
commit 46fa295
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/src/app/core/permissions/permission-directive/disable-entity-operation.directive.ts b/src/app/core/permissions/permission-directive/disable-entity-operation.directive.ts
@@ -1,5 +1,4 @@
 import {
-  ComponentFactoryResolver,
   ComponentRef,
   Directive,
   Input,
@@ -37,19 +36,15 @@ export class DisableEntityOperationDirective implements OnInit, OnChanges {
   constructor(
     private templateRef: TemplateRef<HTMLButtonElement>,
     private viewContainerRef: ViewContainerRef,
-    private componentFactoryResolver: ComponentFactoryResolver,
     private ability: EntityAbility,
     private abilityService: AbilityService
   ) {
     this.abilityService.abilityUpdated.subscribe(() => this.applyPermissions());
   }
 
   ngOnInit() {
-    const containerFactory = this.componentFactoryResolver.resolveComponentFactory(
-      DisabledWrapperComponent
-    );
     this.wrapperComponent = this.viewContainerRef.createComponent(
-      containerFactory
+      DisabledWrapperComponent
     );
     this.wrapperComponent.instance.template = this.templateRef;
     this.wrapperComponent.instance.text = this.text;

diff --git a/src/app/core/view/dynamic-components/dynamic-component.directive.ts b/src/app/core/view/dynamic-components/dynamic-component.directive.ts
@@ -1,5 +1,4 @@
 import {
-  ComponentFactoryResolver,
   Directive,
   Input,
   OnChanges,
@@ -26,7 +25,6 @@ export class DynamicComponentDirective implements OnChanges {
 
   constructor(
     public viewContainerRef: ViewContainerRef,
-    private componentFactoryResolver: ComponentFactoryResolver,
     private registry: ViewRegistry
   ) {}
 
@@ -40,15 +38,11 @@ export class DynamicComponentDirective implements OnChanges {
     }
 
     const component = this.registry.get(this.appDynamicComponent.component);
-    const componentFactory = this.componentFactoryResolver.resolveComponentFactory<OnInitDynamicComponent>(
-      component
-    );
 
     this.viewContainerRef.clear();
 
-    const componentRef = this.viewContainerRef.createComponent<OnInitDynamicComponent>(
-      componentFactory
-    );
+    const componentRef =
+      this.viewContainerRef.createComponent<OnInitDynamicComponent>(component);
     componentRef.instance.onInitFromDynamicConfig(
       this.appDynamicComponent.config
     );