fix(filter): support filters on number fields (#2308)

fixes #1913

src/app/core/filter/filters/filters.spec.ts

@@ -72,4 +72,22 @@ describe("Filters", () => {
     filter.selectedOptionValues = ["true", "false"];
     testFilter(filter, [recordFalse, recordTrue], [recordFalse, recordTrue]);
   });
+
+  it("should support numbers as options", () => {
+    const filter = new SelectableFilter("counts", [], "Counts");
+
+    const keys = [1, 4, 7];
+    filter.options = SelectableFilter.generateOptions(keys, "category");
+
+    expect(filter.options).toHaveSize(keys.length);
+
+    filter.selectedOptionValues = ["1"];
+
+    const testData = [
+      { id: 1, category: 1 },
+      { id: 2, category: 4 },
+    ];
+    const filteredData = testFilter(filter, testData, [testData[0]]);
+    expect(filteredData[0].category).toBe(1);
+  });
 });

src/app/core/filter/filters/filters.ts

@@ -75,13 +75,13 @@ export class SelectableFilter<T extends Entity> extends Filter<T> {
    * @param attributeName The name of the property of a data item that is compared to the value in the filter function.
    */
   public static generateOptions<T extends Entity>(
-    valuesToMatchAsOptions: string[],
+    valuesToMatchAsOptions: (string | number)[],
     attributeName: string,
   ): FilterSelectionOption<T>[] {
     return valuesToMatchAsOptions
       .filter((k) => !!k)
       .map((k) => ({
-        key: k.toLowerCase(),
+        key: k.toString().toLowerCase(),
         label: k.toString(),
         filter: { [attributeName]: k } as DataFilter<T>,
       }));