fix(logging): log DISPLAY_ENTITY and ENTITY_SELECT not_found in more …

…general way
Aam-Digital · Jul 2, 2024 · fd50d3d · fd50d3d
1 parent f7b48f5
commit fd50d3d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/app/core/basic-datatypes/entity/entity-block/entity-block.component.spec.ts b/src/app/core/basic-datatypes/entity/entity-block/entity-block.component.spec.ts
@@ -85,7 +85,9 @@ describe("DisplayEntityComponent", () => {
     await component.ngOnInit();
 
     expect(logSpy).toHaveBeenCalledWith(
-      jasmine.stringContaining(child.getId()),
+      jasmine.stringContaining("Could not find entity"),
+      child.getId(),
+      jasmine.anything(),
     );
     expect(component.entityToDisplay).toBeUndefined();
   });

diff --git a/src/app/core/basic-datatypes/entity/entity-block/entity-block.component.ts b/src/app/core/basic-datatypes/entity/entity-block/entity-block.component.ts
@@ -57,7 +57,9 @@ export class EntityBlockComponent implements OnInit {
     } catch (e) {
       // this may be caused by restrictive permissions and therefore shouldn't be treated as a technical issue
       this.logger.debug(
-        `[DISPLAY_ENTITY] Could not find entity with ID: ${this.entityId}: ${e}`,
+        "[DISPLAY_ENTITY] Could not find entity.",
+        this.entityId,
+        e,
       );
     }
   }

diff --git a/src/app/core/common-components/entity-select/entity-select.component.spec.ts b/src/app/core/common-components/entity-select/entity-select.component.spec.ts
@@ -110,7 +110,9 @@ describe("EntitySelectComponent", () => {
     fixture.detectChanges();
 
     expect(warnSpy).toHaveBeenCalledWith(
-      jasmine.stringContaining("missing_user"),
+      jasmine.stringContaining("ENTITY_SELECT"),
+      "missing_user",
+      jasmine.anything(),
     );
     expect(component.form.value).toEqual([testUsers[0].getId()]);
   }));

diff --git a/src/app/core/common-components/entity-select/entity-select.component.ts b/src/app/core/common-components/entity-select/entity-select.component.ts
@@ -201,7 +201,9 @@ export class EntitySelectComponent<
       .load<E>(type, selectedId)
       .catch((err: Error) => {
         this.logger.warn(
-          `[ENTITY_SELECT] Error loading selected entity "${selectedId}": ${err.message}`,
+          "[ENTITY_SELECT] Error loading selected entity.",
+          selectedId,
+          err.message,
         );
         return undefined;
       });